Skip to content

Revert server side ordering to fix performance issues.#3829

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:revert_modified_order
Nov 21, 2022
Merged

Revert server side ordering to fix performance issues.#3829
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:revert_modified_order

Conversation

@rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Reverts changes to ordering on the server side Channel endpoint made here: 9129835

Manual verification steps performed

  1. Confirm that the channel list page still works

@rtibbles rtibbles requested a review from bjester November 21, 2022 23:25
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 84ba18c into learningequality:hotfixes Nov 21, 2022
@pcenov
Copy link
Member

pcenov commented Nov 22, 2022

@bjester in general everything seems to be functioning correctly. The only problem I'm noticing is when publishing a large channel. Initially it went to 15% but then when I checked back it was displayed as 0% for a period of time, and then when I checked later it was marked as Published, so this is a bit confusing:

2022-11-22_14-31-23

Also while importing the resources for the channel I saw the following error, with seemingly no user facing consequences:

2022-11-22_13-14-32

The channel token is: hizid-juzit

@radinamatic
Copy link
Member

Initially it went to 15% but then when I checked back it was displayed as 0% for a period of time, and then when I checked later it was marked as Published, so this is a bit confusing

This issue was present also during my testing of the last week patch (mentioned in Slack), so may not be caused by the latest changes.

@bjester
Copy link
Member

bjester commented Nov 22, 2022

@pcenov Would you create an issue with some reproduce steps for the original_source_node_id error? That's definitely unrelated.

@pcenov
Copy link
Member

pcenov commented Nov 23, 2022

@bjester hmm I was not able to replicate it again, but if I do, I'll file an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants