Skip to content

Fix missing information on pending task results#3822

Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom
bjester:tasks-extended
Nov 17, 2022
Merged

Fix missing information on pending task results#3822
rtibbles merged 2 commits intolearningequality:hotfixesfrom
bjester:tasks-extended

Conversation

@bjester
Copy link
Member

@bjester bjester commented Nov 17, 2022

Summary

Description of the change(s) you made

  • Manually sets the task name and kwargs on the task result object
  • Adds a new test that validates task result models contain necessary information
  • Updates existing fetch_or_enqueue test to ensure it matches results created through enqueue

Manual verification steps performed

Ran the tests

References

Resolves #3820

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from rtibbles November 17, 2022 16:54
@bjester bjester changed the base branch from unstable to hotfixes November 17, 2022 16:55
@bjester
Copy link
Member Author

bjester commented Nov 17, 2022

I think the test failures and flip-flopping might be caused by the missing add_pending_result-- I'm going to revert and just set the fields where we're setting user and channel

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, and tests give the assurance.

@rtibbles rtibbles merged commit f16a07a into learningequality:hotfixes Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants