Enhance sentry logging for change event application#3810
Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom Nov 10, 2022
Merged
Enhance sentry logging for change event application#3810rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles merged 2 commits intolearningequality:hotfixesfrom
Conversation
bjester
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
$vm0.update({extra_fields: {options: { completion_criteria: {model: 'nah'}}}})in the console to trigger a change that will cause an error during change applicationHave not been able to confirm the sentry logging through testing, but I have followed the API, which allows for
user,contexts,extrasetc. as additional keyword arguments toreport_exception.