Skip to content

Comments

Enhance sentry logging for change event application#3810

Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles:sentry
Nov 10, 2022
Merged

Enhance sentry logging for change event application#3810
rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles:sentry

Conversation

@rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Adds user details and context when logging errors from change application logic
  • Upgrades sentry-vue to latest

Manual verification steps performed

  1. Make a node complete in the edit modal
  2. Select DetailsTabView in the Vue devtools
  3. Execute $vm0.update({extra_fields: {options: { completion_criteria: {model: 'nah'}}}}) in the console to trigger a change that will cause an error during change application
  4. Confirm that the error is still logged properly

Have not been able to confirm the sentry logging through testing, but I have followed the API, which allows for user, contexts, extras etc. as additional keyword arguments to report_exception.

@rtibbles rtibbles requested a review from bjester November 10, 2022 17:03
@rtibbles rtibbles merged commit 8398d72 into learningequality:hotfixes Nov 10, 2022
@rtibbles rtibbles deleted the sentry branch November 10, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants