Prevents reapplication of errored or disallowed changes and resolves issues handling M of N and learner_managed values#3760
Merged
rtibbles merged 3 commits intolearningequality:hotfixesfrom Oct 24, 2022
Conversation
learner_managed values
Member
|
Steps 14-16 did not pass manual testing - but as they seem to not be required for either of the issues being closed here, nor critical behaviour, we can let this go. |
rtibbles
approved these changes
Oct 24, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
learner_managedto be null so that the field is deleted in the serializerManual verification steps performed
allow_null=Truechange to thelearner_managedfieldlearner_managedto nullallow_null=Truechange to thelearner_managedfieldReferences
Fixes #3758
Fixes #3757
Comments
I originally split out #3757 into another issue #3758 but ended up fixing both here
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)