Adds regression test for and fixes metadata label syncing.#3712
Merged
bjester merged 1 commit intolearningequality:unstablefrom Mar 15, 2023
Merged
Adds regression test for and fixes metadata label syncing.#3712bjester merged 1 commit intolearningequality:unstablefrom
bjester merged 1 commit intolearningequality:unstablefrom
Conversation
Member
|
@rtibbles @pcenov Referring to the comment on the former PR, is it clear that the option to sync "Titles and Descriptions" results in syncing these metadata attributes? Should we add a followup issue for updating the copy, or should we block this until we are able to do that? |
Member
Author
|
An excellent question - I think given that we've not annotated any public channels with metadata yet, I think we can block this for now and retarget to unstable? |
837b692 to
1dac0df
Compare
bjester
approved these changes
Mar 15, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
looks good. followup added to address UI concerns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Description of the change(s) you made
Manual verification steps performed
References
Noticed in QA by @pcenov here: #3701 (comment)
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)