Skip to content

Patch django-cte QJoin class to resolve Django 3+ interaction issue#3449

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:patch-django-cte-qjoin
Jul 6, 2022
Merged

Patch django-cte QJoin class to resolve Django 3+ interaction issue#3449
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:patch-django-cte-qjoin

Conversation

@bjester
Copy link
Member

@bjester bjester commented Jul 6, 2022

Summary

Description of the change(s) you made

  • Applies the django-cte fix at startup
  • Resolving this PR will supersede this

Manual verification steps performed

Follow steps here #3385


Reviewer guidance

References

Fixes #3385

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added TAG: dependencies TAG: regression python Pull requests that update Python code labels Jul 6, 2022
@bjester bjester requested a review from rtibbles July 6, 2022 18:40
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense, and the issue is fixed.

@rtibbles rtibbles merged commit 44efd5d into learningequality:hotfixes Jul 6, 2022
@pcenov
Copy link
Member

pcenov commented Jul 7, 2022

Verified as fixed at https://hotfixes.studio.learningequality.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code TAG: dependencies TAG: regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants