fix: use the jspdf https url instead of git://#3349
Merged
rtibbles merged 2 commits intolearningequality:unstablefrom Mar 24, 2022
Merged
fix: use the jspdf https url instead of git://#3349rtibbles merged 2 commits intolearningequality:unstablefrom
rtibbles merged 2 commits intolearningequality:unstablefrom
Conversation
git:// started failing recently, and no docker build can happen
Collaborator
Author
|
Hmm the commit checks are failing, but the overall pull request checks have skipped the failing tests. Is that normal? |
Member
|
@aronasorman You should run |
Collaborator
Author
|
Looks like it's passing @bjester! Btw once you approve I'll squash the fixup into the original commit so the history will look cleaner. |
bjester
approved these changes
Mar 24, 2022
Member
|
I squashed and merged for you @aronasorman to avoid faffing around :) |
rtibbles
pushed a commit
to rtibbles/studio
that referenced
this pull request
Jun 2, 2022
* fix: use the jspdf https url instead of git:// git:// started failing recently, and no docker build can happen * fixup! fix: use the jspdf https url instead of git:// Co-authored-by: Aron Asor <aron@noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git:// started failing recently, and no docker build can happen
Summary
Description of the change(s) you made
Github recently deprecated the git:// url for pulling in dependencies. We still have jsPDF using that git:// url, so docker builds on all branches should be failing.
Unstable failed build
Hotfixes failed build
This fix simply changes the git:// url to an https:// url. And builds are now succeeding on my end!
Manual verification steps performed
Run a docker build:
docker build -f k8s/images/app/Dockerfile .