Skip to content

Move minio to dev requirements, update urllib3#3271

Merged
rtibbles merged 2 commits intolearningequality:unstablefrom
bjester:minio-dev-only
Aug 31, 2021
Merged

Move minio to dev requirements, update urllib3#3271
rtibbles merged 2 commits intolearningequality:unstablefrom
bjester:minio-dev-only

Conversation

@bjester
Copy link
Member

@bjester bjester commented Aug 31, 2021

Summary

Description of the change(s) you made

Makes minio a dev dependency instead and avoids loading it if the storage backend is GCS

Manual verification steps performed

  1. Dev server starts up

Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

Resolves dependabot security advisory: https://github.com/learningequality/studio/security/dependabot/requirements.txt/urllib3/closed


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, devserver runs.

@rtibbles
Copy link
Member

Don't know what SonarCloud's problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants