Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfixes release for last 2 sprints ending 2021-08-02 #3247

Merged
merged 74 commits into from
Aug 12, 2021
Merged

Hotfixes release for last 2 sprints ending 2021-08-02 #3247

merged 74 commits into from
Aug 12, 2021

Conversation

bjester
Copy link
Member

@bjester bjester commented Jul 19, 2021 •
edited
Loading

Summary

  • Fixes handling of default setting for randomization of exercise questions
  • Fixes issue resulting in duplicate server syncing requests when multiple tabs are used
  • Fixes cross-origin issue when signing out
  • Fixes cosmetic issue in related resources management
  • Fixes potential performance issue when editing markdown
  • Fixes bug in developer setup after Django upgrade
  • Adds cron job to invoke garbage collection command which now cleans up completed tasks
  • Small code refactors from technical debt identified by deepsource.io and SonarCloud
PR Issues Category QA Focus
#3253 #3244 Bug fix Verify channel exercise setting in export
#3251, #3256 #3191 Bug fix Edit channel with multiple tabs open
#3255 N/A Cosmetic fix Previewing related resource in drawer
#3254 N/A Bug fix Sign out clears local data
#3252 N/A Bug fix Adding topic doesn't cause console error
#3236 N/A Performance Edit rich exercise content
#3066 N/A Tech debt Critical workflows
#3221 N/A Tech debt Critical workflows
#3220 N/A Tech debt Critical workflows
#3222 N/A Tech debt Critical workflows
#3219 N/A Tech debt Critical workflows
#3223 N/A Tech debt Critical workflows
#3229 N/A Tech debt Critical workflows
#3211 N/A Tech debt Critical workflows
#3230 N/A Tech debt Critical workflows
#3232 N/A Tech debt Critical workflows
#3228 N/A Tech debt Critical workflows
#3231 N/A Tech debt Critical workflows
#3242 N/A Tech debt Critical workflows
#3238 N/A Tech debt Critical workflows
#3241 N/A Tech debt Critical workflows
#3239 N/A Tech debt Critical workflows
#3240 N/A Tech debt Critical workflows
#3237 N/A Tech debt Critical workflows
#3257 N/A Security update N/A
#3233 N/A Dev fix N/A

QA Scenarios

Verify exercise randomization setting in channel export

  1. Open a channel for editing
  2. Click ADD and select New Exercise
  3. Do not change the setting for Randomize question order for learners
  4. Add Title, Mastery model, License, and at least one question then save the exercise
  5. Publish the channel
  6. Manually download the channel database https://hotfixes.studio.learningequality.org/content/databases/<CHANNEL_ID>.sqlite3
  7. Use SQLite browser tool or CLI to inspect content_assessmentmetadata table and verify randomize value is 1
  8. Repeat scenario, unsetting the randomize option

Edit channel with multiple tabs open

  1. Open a channel for editing
  2. Duplicate the tab
  3. Open the Developer Console in both tabs and go to the Network tab of each console
  4. Refresh both tabs
  5. Ensure only one tab registers requests to a sync URL

Previewing related resource in drawer

  1. Open a channel for editing
  2. Add or edit an exercise
  3. Click RELATED tab
  4. Click either ADD NEXT STEP or ADD PREVIOUS STEP
  5. Click PREVIEW on a resource
  6. Verify you can scroll to the bottom of the preview drawer

Sign out clears local data

  1. Open a channel for editing
  2. Open the Developer Console and go to the Application tab
  3. Sign out
  4. Verify that there's no data inside Developer Console > Application > Storage > IndexedDB > Kolibri Studio > contentnode

Adding topic doesn't cause console error

  1. Open a channel for editing
  2. Open the Developer Console and go to the Console tab
  3. Click ADD and select New Topic
  4. Verify there's no error in console

Edit rich exercise content

  1. Open a channel for editing
  2. Click ADD and select New Exercise
  3. Add Title, Mastery model, and License
  4. Click the QUESTIONS tab
  5. Click NEW QUESTION
  6. Use tools to add rich text into the Question, Answer, and/or Hint textboxes

Critical workflows

deepsource-autofix bot and others added 30 commits July 6, 2021 14:25
@deepsource-autofix @rtibbles
Replace short hand type conversions with JavaScript methods
3c50dd1
@deepsource-autofix
Remove unnecessary use of comprehension
979bcab
@deepsource-autofix
Replace assertEquals with assertEqual
e1795a4
@deepsource-autofix
Replace ==/!= with ===/!==
0343954
@deepsource-autofix
Replace list comprehension with set comprehension
e26b581
@deepsource-autofix
Remove reimported module
361cb4d
@rtibbles
Merge pull request learningequality#3221 from learningequality/deepso…
71980d2 
…urce-fix-a29486d6

Replace  `==`/`!=` with `===`/`!==`
@rtibbles
Update models reference
3c417f5
@rtibbles
Merge pull request learningequality#3220 from learningequality/deepso…
92f22d7 
…urce-fix-ddeef224

Replace `assertEquals` with `assertEqual`
@rtibbles
Merge pull request learningequality#3222 from learningequality/deepso…
24f806c 
…urce-fix-5580e907

Replace list comprehension with set comprehension
@rtibbles
Merge pull request learningequality#3219 from learningequality/deepso…
8c61b6f 
…urce-fix-89e9f703

Remove unnecessary use of comprehension
@rtibbles
Merge pull request learningequality#3223 from learningequality/deepso…
b6fc37b 
…urce-fix-2ef385ca

Remove reimported module
@deepsource-autofix
Use identity check for comparison to a singleton
c1bcb29
@rtibbles
Lint
70836ca
@deepsource-autofix
Remove assert statement from non-test files
4947bda
@rtibbles
Merge pull request learningequality#3229 from learningequality/deepso…
83ce9cf 
…urce-fix-f1d0fd14

Remove assert statement from non-test files
@rtibbles
Merge pull request learningequality#3211 from learningequality/deepso…
63be85b 
…urce-fix-c273c78e

Replace short hand type conversions with JavaScript methods
@deepsource-autofix
Remove length check in favour of truthiness of the object
f6e6aed
@deepsource-autofix
Refactor unnecessary else / elif when if block has a raise st…
b92cae0 
…atement
@deepsource-autofix
Use literal syntax instead of function calls to create data structure
f04f2c5
@rtibbles
Merge pull request learningequality#3230 from learningequality/deepso…
21266b3 
…urce-fix-d330b87d

Remove length check in favour of truthiness of the object
@rtibbles
Merge pull request learningequality#3232 from learningequality/deepso…
7436409 
…urce-fix-59592cc6

Use literal syntax instead of function calls to create data structure
@rtibbles
Merge pull request learningequality#3228 from learningequality/deepso…
3ab9a3b 
…urce-fix-44ffe5ee

Use identity check for comparison to a singleton
@rtibbles
Merge pull request learningequality#3231 from learningequality/deepso…
aed2a29 
…urce-fix-918e0e01

Refactor unnecessary `else` / `elif` when `if` block has a `raise` statement
@rtibbles
Warn when trying to publish channel with incomplete root node.
cbf53c7 
Catch integrity error to handle both sides of missing prerequisite relationships.
@rtibbles
Don't mark root nodes as incomplete.
cad81de
@rtibbles
Don't await synchronous function
8849cd4
@rtibbles
Merge pull request learningequality#3233 from rtibbles/fix_setup
4bdda0f 
Fix setup
@rtibbles
Use regex test instead of match for existence
7868225
@deepsource-autofix
Remove redundant None default
211a369
@bjester bjester changed the title Hotfixes release for sprint ending 2021-07-19 Hotfixes release for last 2 sprints ending 2021-08-02 Aug 4, 2021
Aron Asor and others added 20 commits August 4, 2021 19:33
@rtibbles
add cronjob that clears old tasks every midnight
5b57646
@rtibbles
Prevent unnecessary MPTT operations in garbage collection.
a4be8dd
@rtibbles
Add task clean up to garbage collection.
76ed3f8
@rtibbles
Do garbage collection cronjob instead of just task cleanup.
5f9b055
@bjester
Merge pull request learningequality#3252 from rtibbles/undefined_
dee1290 
Handle a ref being undefined during computed prop computation.
@bjester
Merge pull request learningequality#3253 from rtibbles/randomize
3523d71 
Make randomize default to true in the frontend
@rtibbles
Remove API request consolidation across tabs.
ae74ae3
@rtibbles
Consolidate garbage collection tests.
c502574
@aronasorman @rtibbles
Update k8s/templates/garbage-collect-cronjob.yaml
7acb364 
Co-authored-by: Richard Tibbles <richard@learningequality.org>
@bjester
Merge pull request learningequality#3066 from aronasorman/clear-old-t…
8c4cf8e 
…asks-cronjob

add cronjob that clears old tasks every midnight
@rtibbles
Universally mock client and urls.
5711dd4
@rtibbles
Cleanup logging in tests to make errors stand out better.
555b307
@rtibbles
Clean up yarn test commands.
b9eabae
@rtibbles
Consolidate global mocks.
6d40f84
@rtibbles
Add defensive checks.
9a9eddd
@rtibbles
Stub/mock async behaviour.
79388d2
@rtibbles
Mock async created calls in channelsetmodal tests.
98b5105 
Lint.
@dependabot
Bump path-parse from 1.0.6 to 1.0.7
7c3ea30 
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@marcellamaki
Merge pull request learningequality#3256 from rtibbles/fetch_not_request
830d965 
Remove API request consolidation across tabs.
@rtibbles
Merge pull request learningequality#3257 from learningequality/depend…
d695e45 
…abot/npm_and_yarn/path-parse-1.0.7

Bump path-parse from 1.0.6 to 1.0.7
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bjester bjester marked this pull request as ready for review August 12, 2021 16:59
@rtibbles rtibbles merged commit 967ba6e into learningequality:hotfixes Aug 12, 2021
@radinamatic
Copy link
Member

radinamatic commented Aug 12, 2021 •
edited
Loading

Apologies for the delay, @pcenov finished running the critical workflows on Friday, only I was dragging my feet to confirm specific test scenarios for this sprint...

PR Issues Category QA Focus Status img
#3253 #3244 Bug fix Verify channel exercise setting in export ✔️ DB Browser for SQLite - -home-didi-Documents-LE-WIP-QA-210812-7184393530e64079885ed58467df29e8-unchecked sqlite3_001
#3251, #3256 #3191 Bug fix Edit channel with multiple tabs open ✔️
#3255 N/A Cosmetic fix Previewing related resource in drawer ✔️
#3254 N/A Bug fix Sign out clears local data ✔️
#3252 N/A Bug fix Adding topic doesn't cause console error ✔️
#3236 N/A Performance Edit rich exercise content ✔️ Edit details - test size - Kolibri Studio - Google Chrome_001 Few errors in the console while uploading images in question, answer and hint fields, and one during publishing, which completed successfully irregardless. test size - test size - Kolibri Studio - Google Chrome_003

@radinamatic
Copy link
Member

@bjester this looks good to go in production, no regressions in sight! 💯 👏🏽

@bjester bjester mentioned this pull request Aug 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjester @radinamatic @rtibbles @aronasorman @marcellamaki