Feature flag support#3129
Merged
rtibbles merged 10 commits intolearningequality:unstablefrom May 3, 2021
Merged
Conversation
bjester
commented
May 3, 2021
| annotations["editable_channels__ids"] = NotNullArrayAgg("editable_channels__id") | ||
| annotations["view_only_channels__ids"] = NotNullArrayAgg( | ||
| "view_only_channels__id" | ||
| ) |
Member
Author
There was a problem hiding this comment.
These fields weren't used anywhere
rtibbles
approved these changes
May 3, 2021
Member
rtibbles
left a comment
There was a problem hiding this comment.
Works precisely as I would expect!
| from django.conf.urls import include | ||
| from django.conf.urls import url | ||
| from django.conf.urls.i18n import i18n_patterns | ||
| from django.contrib import admin |
Member
There was a problem hiding this comment.
Hah, my linter also just picked this up.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows for customization of Studio behavior on per-user basis through features defined in a static JSON file and granted through the admin interface.
Description of the change(s) you made
feature_flagsJSONB column to the User modeljsonschemadependency and resolves cross-dependency versioning conflictsstaticalias to Webpack for loading JSON schema on frontendAdminUserViewSetManual verification steps performed
python manage.py garbage_collectScreenshots (if applicable)
References
Resolves #3120
Comments
In the above issue it has the following deliverable:
I did not follow the above deliverable because the save button is contained in a standalone component which would either require additional refactoring or would otherwise not be nominally understandable. Instead I added it below and used a
KSwitchwhich is expected to apply the change immediately (without the need for a save button).Contributor's Checklist
PR process:
requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)