Skip to content

Release 2021-02-15#2947

Merged
rtibbles merged 7 commits intomasterfrom
hotfixes
Feb 15, 2021
Merged

Release 2021-02-15#2947
rtibbles merged 7 commits intomasterfrom
hotfixes

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Feb 12, 2021

Fixes for:
#2942
#2943
#2899

Scenario to test:

Given: You are not logged in.
When: You go to the login page.
And: You enter your email address with a space at the end
And: Enter your password correctly
Then: You should be logged in successfully
Given: You are logged in as a non-admin.
When: You go to import from other channels.
Then: You should not see duplicates of channels.

@rtibbles rtibbles added this to the Post Release Stabilization milestone Feb 12, 2021
@rtibbles rtibbles requested a review from radinamatic February 12, 2021 18:48
@radinamatic
Copy link
Member

radinamatic commented Feb 12, 2021

Good to go! 👍

(Wrong PR)
2493 did not have specific steps to test, so I tested various scenarios and filtering options. Seems it is behaving as described there: searching and filtering works with subsets, but not with full Content library.

Import from other channels - Test0211 - Kolibri Studio - Google Chrome_012

radinamatic
radinamatic previously approved these changes Feb 12, 2021
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good and ready to go! 💯

@metodimilevqa
Copy link

I confirm the fix, tested at the hotfixes environment.

Avoid left join when filtering for channel permissions
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the #2948 with non-admin Studio user, no duplicate channels in sight!

@rtibbles rtibbles merged commit a90f07a into master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants