Conversation
Updates to create channel internal endpoint to handle custom channel navigation creation
Trim whitespace for email addresses
Member
radinamatic
previously approved these changes
Feb 12, 2021
Member
radinamatic
left a comment
There was a problem hiding this comment.
All good and ready to go! 💯
|
I confirm the fix, tested at the hotfixes environment. |
Avoid left join when filtering for channel permissions
radinamatic
approved these changes
Feb 15, 2021
Member
radinamatic
left a comment
There was a problem hiding this comment.
Tested the #2948 with non-admin Studio user, no duplicate channels in sight!
kollivier
approved these changes
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes for:
#2942
#2943
#2899
Scenario to test: