Skip to content

Comments

Use the images upload menu when an image dropped#2332

Merged
jayoshih merged 1 commit intolearningequality:developfrom
MisRob:image-drop
Sep 29, 2020
Merged

Use the images upload menu when an image dropped#2332
jayoshih merged 1 commit intolearningequality:developfrom
MisRob:image-drop

Conversation

@MisRob
Copy link
Member

@MisRob MisRob commented Sep 28, 2020

Description

Do not trigger image upload and do not display an image in the content area of the markdown editor immediately after drop. Instead, open the images upload menu with the image and let the menu handle the rest of the upload and insert process.

Issue Addressed

Closes #2177

Steps to Test

  • Drop an image into the markdown editor content area

Checklist

  • Is the code clean and well-commented?
  • Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  • Are there tests for this change?
  • Are all user-facing strings translated properly (if applicable)?
  • Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Are views organized into pages, components, and layouts directories as described in the docs?
  • Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  • Are there any new interactions that need to be added to the QA Sheet?
  • Are there opportunities for using Google Analytics here (if applicable)?
  • If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  • Are the migrations safe for a large db (if applicable)?

@MisRob MisRob added needs review qa-ready Create a demo server for this pull request labels Sep 28, 2020
@MisRob MisRob added this to the Vue Refactor milestone Sep 28, 2020
@MisRob
Copy link
Member Author

MisRob commented Sep 28, 2020

Regarding dropping more images than one, there's an issue - please see the last comment.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2332 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2332   +/-   ##
========================================
  Coverage    81.46%   81.46%           
========================================
  Files          293      293           
  Lines        14106    14106           
========================================
  Hits         11491    11491           
  Misses        2615     2615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf3f74...6f51219. Read the comment docs.

@MisRob MisRob removed the qa-ready Create a demo server for this pull request label Sep 28, 2020
@jayoshih jayoshih merged commit 82d7b02 into learningequality:develop Sep 29, 2020
@MisRob MisRob deleted the image-drop branch November 3, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open the image upload menu and upload the image from there after it was dropped to the content area of the markdown editor

3 participants