Use the images upload menu when an image dropped#2332
Merged
jayoshih merged 1 commit intolearningequality:developfrom Sep 29, 2020
Merged
Use the images upload menu when an image dropped#2332jayoshih merged 1 commit intolearningequality:developfrom
jayoshih merged 1 commit intolearningequality:developfrom
Conversation
Member
Author
|
Regarding dropping more images than one, there's an issue - please see the last comment. |
Codecov Report
@@ Coverage Diff @@
## develop #2332 +/- ##
========================================
Coverage 81.46% 81.46%
========================================
Files 293 293
Lines 14106 14106
========================================
Hits 11491 11491
Misses 2615 2615 Continue to review full report at Codecov.
|
jayoshih
approved these changes
Sep 29, 2020
micahscopes
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not trigger image upload and do not display an image in the content area of the markdown editor immediately after drop. Instead, open the images upload menu with the image and let the menu handle the rest of the upload and insert process.
Issue Addressed
Closes #2177
Steps to Test
Checklist
docslabel been added if this introduces a change that needs to be updated in the user docs?CHANGELOGlabel been added to this pull request? Items with this label will be added to the CHANGELOG at a later timenotranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?pages,components, andlayoutsdirectories as described in the docs?