Added admin page tests#1981
Merged
rtibbles merged 1 commit intolearningequality:developfrom Jul 7, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1981 +/- ##
========================================
Coverage 79.38% 79.38%
========================================
Files 274 274
Lines 13134 13134
========================================
Hits 10427 10427
Misses 2707 2707 Continue to review full report at Codecov.
|
rtibbles
approved these changes
Jul 7, 2020
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
All test descriptions make sense to me - and from a brief skim of the contents, seem to be testing the right thing! Should give people confidence to make changes if they have to touch the code in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests and created a separate channel details modal as per this comment