Skip to content

Audit and fix theme token updates against KDS #4439

@marcellamaki

Description

@marcellamaki

Overview

In support of planned patch 1, we need to ensure that our token mapping is properly upgraded, in particular where there are changes to the components token map (i.e. previously a primary token, but now needs to be the color of the secondary token). @rtibbles has a draft of this work to ensure it was working, on a previous version of the KDS upgrades.

To Do

Review Studio against KDS token updates (pending PR). Some updates may need to be made in KDS, and some may need to be made in Studio.
General areas of consideration:

  • App bar updates
  • Vuetify colors (ask @rtibbles for more context if needed)
  • learning activity icons
  • icons generally
  • hover states and active states

Search codebase for:

  • references to tokens that are added in to custom components. Particularly primary and secondarytokens. Ask if there are any questions about which is the appropriate token going forward
  • Hex codes that do not belong

Manually review:

  • Links, form elements, and/or text with insufficient contrast (this would be edge cases)

Designers and Radina should review once the PR is merged.

@bjester should determine where to target the PR

@marcellamaki @jtamiace @tomiwaoLE @radinamatic and @rtibbles are available for support

Metadata

Metadata

Assignees

Labels

P0 - criticalPriority: Release blocker or regression

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions