Continue button on privacy policy modal is clickable even when the "I have agreed the above terms" checkbox is not checked

[akolson]

Desired behavior

The "Continue" button should not be clickable(should be disabled) if the "I have agreed the above terms" checkbox is not checked

Current behavior

The "Continue" button is clickable even if the "I have agreed the above terms" checkbox is not checked. As much as this presents a error message to the user on clicking the button and doesn't fire the button action, this doesn't present good user experience in my opinion.

Value add

This provides better users experience from a users point of view

Possible tradeoffs

---

Add labels

[manavagr1108]

Hey @akolson, I am willing to work on this issue. Can I take up this issue?

[akolson]

HI @manavagr1108, sure this issue is available for you to pickup. Based on your question under the gsoc channel, it seems you have already taken it up. Thank you very much. Now regarding your question, have you run studio before, or this is the first time you are running it?

[manavagr1108]

I have already set up the repo and it's working locally in my system. But I am unable to reproduce the updated privacy policy modal in my local. Can u help me reproduce this so that I can test the changes that I have made.

[akolson]

The modal is meant to show up on the very first login into studio, but will also continue to show up on every login if you haven't agreed to the policies. If you have already had multiple logins, I would recommend you remove all the docker volumes and images and then restart the set up process. If you are using docker desktop, removing volumes and images should be relatively easy to do but you can also accomplish the same using docker commands.

[akolson]

That is;

1. Ensure that you stop running docker services(Ctrl + C) and remove the containers using make dcservicesdown
2. Delete all docker images and volumes. Use any of Docker desktop or cmd
3. For good measure, please clear browser cache related to the local studio
4. Run make run-services. This will run all docker services including the celery worker
5. Then yarn run devsetup in another terminal
6. Once 5. is complete you can finally run yarn run devserver
7. Login at localhost:8080 using a@a.com as email and a as password and the modal(s) should show-up

[manavagr1108]

Its working now. Thank you @akolson. I will test the changes and push the code.