Fix issue that causes learners to skip every other question in an exercise#9819
Merged
marcellamaki merged 1 commit intolearningequality:release-v0.15.xfrom Nov 9, 2022
Merged
Conversation
Member
|
Yep, finally seeing the same order of questions in Kolibri exercise as it is on Studio, when the Randomize order... option is unchecked! 💯 cc @pcenov to confirm the fix so we can approve and merge for the upcoming patch. |
Add assertions for totalattempts behaviour in existing tests.
radinamatic
approved these changes
Nov 9, 2022
Member
radinamatic
left a comment
There was a problem hiding this comment.
Manual QA passes, good to go! 💯 ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
totalattemptsbeing incremented twice on the client side when an attempt was submitted, which is then used to determine the next question to display - which was then skipping every other question, as it was going up by 2 at a time instead of 1.Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarnandpip)