Skip to content

Fix issue that causes learners to skip every other question in an exercise#9819

Merged
marcellamaki merged 1 commit intolearningequality:release-v0.15.xfrom
rtibbles:try_hard
Nov 9, 2022
Merged

Fix issue that causes learners to skip every other question in an exercise#9819
marcellamaki merged 1 commit intolearningequality:release-v0.15.xfrom
rtibbles:try_hard

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 8, 2022

Summary

  • During testing of Studio hotfixes, an issue became apparent that Kolibri was only displaying every other question of an exercise when the questions were not randomized
  • It became apparent that this was caused by the totalattempts being incremented twice on the client side when an attempt was submitted, which is then used to determine the next question to display - which was then skipping every other question, as it was going up by 2 at a time instead of 1.

Reviewer guidance

  • Verify that questions are now displayed in proper order

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 8, 2022
@rtibbles rtibbles added this to the Planned Patch 7 milestone Nov 8, 2022
@radinamatic
Copy link
Member

Yep, finally seeing the same order of questions in Kolibri exercise as it is on Studio, when the Randomize order... option is unchecked! 💯

Selection_068

cc @pcenov to confirm the fix so we can approve and merge for the upcoming patch.

Add assertions for totalattempts behaviour in existing tests.
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 :shipit:

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marcellamaki marcellamaki merged commit 8c90ab9 into learningequality:release-v0.15.x Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TODO: needs review Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants