Skip to content

Conversation

@christianmemije
Copy link
Contributor

@christianmemije christianmemije commented Jul 16, 2018

Summary

This PR will:

  • Make vue component names PascalCase. ✔️
  • Make vue component names required. ✔️
  • Standardize on plugin root component names. PluginNameRoot. ✔️
  • Enforce vue filename conventions. ✔️
  • Make component registration PascalCase. ✔️

Follow up


Contributor Checklist

  • Contributor has fully tested the PR manually
  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If there are any front-end changes, before/after screenshots are included
  • If this is an important user-facing change, PR or related issue has a 'changelog' label

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #4034 into develop will increase coverage by 0.1%.
The diff coverage is 43.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #4034     +/-   ##
==========================================
+ Coverage    49.91%   50.01%   +0.1%     
==========================================
  Files          628      628             
  Lines        20827    20828      +1     
  Branches      2688     2688             
==========================================
+ Hits         10395    10417     +22     
+ Misses        9760     9742     -18     
+ Partials       672      669      -3
Impacted Files Coverage Δ
...ment/assets/src/state/actions/deviceInfoActions.js 0% <ø> (ø) ⬆️
...sets/src/views/buttons-and-links/KExternalLink.vue 100% <ø> (ø)
...s/document_pdf_render/assets/src/views/PdfPage.vue 0% <ø> (ø)
kolibri/core/assets/src/views/ElapsedTime.vue 57.14% <ø> (ø)
kolibri/core/assets/src/views/KCheckbox.vue 78.94% <ø> (ø)
kolibri/core/assets/src/views/KCircularLoader.vue 100% <ø> (ø)
kolibri/core/assets/src/views/KRadioButton.vue 80% <ø> (ø)
kolibri/core/assets/src/views/CoreMenu/index.vue 16.66% <ø> (ø)
kolibri/core/assets/src/views/ProgressBar.vue 100% <ø> (ø)
.../facility_management/assets/src/views/UserRole.vue 0% <ø> (ø)
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576a79e...1bae00a. Read the comment docs.

@christianmemije christianmemije added the TODO: needs review Waiting for review label Jul 18, 2018
@@ -1,5 +1,5 @@
{
"tagname-lowercase": true,
"tagname-lowercase": false,

This comment was marked as spam.

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@indirectlylit indirectlylit merged commit 0c0974c into learningequality:develop Jul 19, 2018
@indirectlylit indirectlylit changed the title Vue Casing (WIP) Vue Casing Jul 19, 2018
@christianmemije christianmemije deleted the VueCasing branch September 19, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TODO: needs review Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants