Bump stylelint-scss from 5.3.2 to 7.0.0#14492
Bump stylelint-scss from 5.3.2 to 7.0.0#14492dependabot[bot] wants to merge 1 commit intodevelopfrom
Conversation
dependabot
bot
added
dependencies
rtibblesbot
left a comment
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency update review for stylelint-scss 5.3.2 → 7.0.0 (multi-major jump; v6 was intentionally skipped per ignore conditions).
Package: stylelint-scss 5.3.2 → 7.0.0
Semver risk: Multi-major (high)
Dependency type: devDependency (linting)
CI status: Passing (lint, frontend tests, all Python versions)
Changelog Analysis
Sources consulted:
- PR body release notes (v6.0.0–v7.0.0)
- Compare v5.3.2...v7.0.0
Breaking changes (v7.0.0):
- Removed Node.js < 20.19.0 support — project already requires
>= 20.19.0inengines, no impact - Removed 4 deprecated
@importrules (at-import-no-partial-leading-underscore,at-import-partial-extension-blacklist,at-import-partial-extension-whitelist,at-import-partial-extension) — none are used in.stylelintrc.js, no impact - Changed to ES Modules (#931) — stylelint loads plugins via its own mechanism; CI lint passes
- Peer dependency changed to
stylelint ^16.8.2 || ^17.0.0— the project pinsstylelint: ^15.11.0. See blocking finding below. - Added
selector-class-patternrule — already set tonullin the project's.stylelintrc.js
Breaking changes (v6.0.0): Skipped entirely by this PR (v6 was in the ignore conditions >= 6.a, < 7).
Deprecations: None noted.
Security fixes: None.
Compatibility Assessment
- Project uses affected APIs: no (removed rules not in config)
- Peer dependency mismatch: yes —
stylelint-scss@7.0.0requiresstylelint ^16.8.2 || ^17.0.0, but the project hasstylelint@^15.11.0(resolves to 15.11.0). pnpm installed it anyway, and CI passes, but this is an unsupported combination. - Code changes required: no source changes needed, but
stylelintitself should be upgraded to satisfy the peer dependency - Prior failed attempts: v6 was previously ignored
Recommendation
REQUEST_CHANGES — peer dependency mismatch must be resolved. See inline comment.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Reviewed the pull request diff checking for:
- Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
- Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
- Architecture: duplicated concerns, minimal interfaces, composition over inheritance
- Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
- Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
- Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
- Checked CI status and linked issue acceptance criteria
- For UI changes: inspected screenshots for layout, visual completeness, and consistency
| "stylelint-config-standard": "34.0.0", | ||
| "stylelint-csstree-validator": "3.0.0", | ||
| "stylelint-scss": "5.3.2" | ||
| "stylelint-scss": "7.0.0" |
There was a problem hiding this comment.
blocking: stylelint-scss@7.0.0 declares peerDependencies: { stylelint: "^16.8.2 || ^17.0.0" }, but this package has stylelint: "^15.11.0". The lockfile resolves it against stylelint 15.11.0 — an unsupported combination.
CI lint passes today, but upstream bug fixes and new rules may only be tested against stylelint 16/17. This could lead to silent breakage that's difficult to diagnose.
Guidance: Upgrade stylelint to ^16.8.2 (or ^17.0.0) in this same PR, along with any config packages that may need corresponding updates (stylelint-config-standard, stylelint-config-recommended-scss, etc.). Alternatively, if a stylelint upgrade is too large to bundle here, consider staying on stylelint-scss@6.x which supports stylelint ^16.8.2 — though that would also require upgrading stylelint from 15.
Build Artifacts
Smoke test screenshot |
Bumps [stylelint-scss](https://github.com/stylelint-scss/stylelint-scss) from 5.3.2 to 7.0.0. - [Release notes](https://github.com/stylelint-scss/stylelint-scss/releases) - [Changelog](https://github.com/stylelint-scss/stylelint-scss/blob/master/CHANGELOG.md) - [Commits](stylelint-scss/stylelint-scss@v5.3.2...v7.0.0) --- updated-dependencies: - dependency-name: stylelint-scss dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/stylelint-scss-7.0.0
branch
from
177c55f to
f3b4ecd
Compare
rtibblesbot
left a comment
rtibblesbot
left a comment
There was a problem hiding this comment.
Prior findings
Unaddressed (re-raised below):
- Peer dependency mismatch:
stylelint-scss@7.0.0requiresstylelint ^16.8.2 || ^17.0.0but project has^15.11.0(blocking) — no reply, no code change
0/1 prior findings resolved. 1 re-raised below.
Dependency Update Review
Package: stylelint-scss 5.3.2 → 7.0.0
Semver risk: Multi-major (high)
Dependency type: devDependency (linting)
CI status: Passing
No new commits since prior review. The blocking peer dependency mismatch remains: stylelint-scss@7.0.0 declares peerDependencies: { stylelint: "^16.8.2 || ^17.0.0" }, but the project pins stylelint: "^15.11.0". See inline comment.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Compared the current PR state against findings from a prior review:
- Retrieved prior bot reviews deterministically via the GitHub API
- Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
- Only raised NEW findings for newly introduced code
- Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
- Checked CI status and linked issue acceptance criteria
| "stylelint-config-standard": "34.0.0", | ||
| "stylelint-csstree-validator": "3.0.0", | ||
| "stylelint-scss": "5.3.2" | ||
| "stylelint-scss": "7.0.0" |
There was a problem hiding this comment.
blocking: (re-raised from prior review — unaddressed)
stylelint-scss@7.0.0 declares peerDependencies: { stylelint: "^16.8.2 || ^17.0.0" }, but this package has stylelint: "^15.11.0". CI passes today because pnpm installed it anyway, but this is an unsupported combination — upstream only tests against stylelint 16/17, so future rule behavior may silently diverge.
Guidance: Either upgrade stylelint to ^16.8.2 in this PR (along with any config changes the major bump requires), or close this PR and open a combined stylelint + stylelint-scss upgrade.
1 participant
Bumps stylelint-scss from 5.3.2 to 7.0.0.
Release notes
Sourced from stylelint-scss's releases.
... (truncated)
Changelog
Sourced from stylelint-scss's changelog.
... (truncated)
Commits
6a0db057.0.0341c28cMerge pull request #1227 from stylelint-scss/v77e94463Bump stylelintd4f1249Document 7.0.0 changelog (#1223)cd3f43fRemove deprecated rules (#1220)e24b0b6Addselector-class-patternrule (#1219)7dccb82Remove support for Node.js 18 (#1221)78ccda6Add support for Stylelint 17 (#1222)e1c86b6Change module type to ESM (#1224)56b5efb6.14.0Most Recent Ignore Conditions Applied to This Pull Request