Cherry picks BEGIN IMMEDIATE for all SQLite transactions to improve performance #13909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
DEV: backend
…etter matches intended behaviour in our codebase.
marcellamaki
force-pushed
the
hotfix_flying_colors_performance
branch
from
ecb49bd to
6c6de37
Compare
Contributor
Member
|
Seems like we will be encouraging upgrade to 0.19.0 instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on reported feedback from Flying Colors YIDA staff, we learned of data loss due to too many server requests. This change better matches the intended behavior and prevents the server from getting overwhelmed and having many failed requests.
Reviewer guidance
This fix has been verified in 0.19.x, but the key testing here is ensuring that there are not regressions or any other issues/concers if we share this installer with the YIDA team to upgrade.