Updates empty filter state messaging #13762
Conversation
github-actions
bot
added
APP: Facility
Build Artifacts
|
…s match filters or search terms.
AllanOXDi
force-pushed
the
filtersupdate
branch
from
b732c09 to
b62ec64
Compare
| }, | ||
|
|
||
| noUsersMatchFilter: { | ||
| message: 'No users match this filter', |
There was a problem hiding this comment.
When @marcellamaki noted:
"No users match this filter" || "No users match these filters"
I think she meant that there would be differentiation between singular "this filter" and plural "these filters" when the user has selected only 1 vs more than 1 filter kinda like 'No users match {filtersCount, plural, one {this filter}, other {these filters}'
| }, | ||
|
|
||
| noUsersMatchFiltersAndSearch: { | ||
| message: 'No users match this search and this filter', |
There was a problem hiding this comment.
The other complication would be making this have a similar filtersCount property which changes between this filter and these filters depending on the value you pass into the string function.
| context: 'Side panel H1 heading showing the number of selected users to assign as coaches', | ||
| }, | ||
|
|
||
| noUsersMatch: { |
There was a problem hiding this comment.
I don't see where this string is used.
| if (roleFilter.value && roleFilter.value.value !== ALL_FILTER) { | ||
| return noUsersMatchFiltersAndSearch$(); | ||
| } | ||
| return noUsersMatchSearch$({ filterText: searchTerm.value }); |
There was a problem hiding this comment.
Related to comments I left in the strings file - I think the logic here is right so you'd just have to pass in the proper number value of filters that are set ie noUsersMatchFiltersAndSearch$({filtersCount: ...}) for this and the other message
Summary
This PR updates the logic and message displayed when the user list is empty due to active filters or search terms.
Previously, we were using the generic "No users exist" message.
closes #13758
References
#13758
Reviewer guidance
Navigate to > users try searching for users that are not in the facility > filter roles that don't exist yet still.