-
Notifications
You must be signed in to change notification settings - Fork 803
Remove deep KTextTruncator styles from AccessibleResourceCard #13392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deep KTextTruncator styles from AccessibleResourceCard #13392
Conversation
WalkthroughThe changes remove a custom CSS override from the AccessibleResourceCard component and update the kolibri-design-system dependency in the kolibri package to reference a specific commit from a GitHub repository instead of a version number. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to styling and dependency updates, without affecting control flow or feature logic. Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Build Artifacts
|
Thanks @AlexVelezLl - I confirm that this is implemented as specified and there are no regressions. |
Manual QA passed, needs code review and approval! 🙂 |
d64c7d2
to
d69ea45
Compare
d69ea45
to
24d897e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are 👍
Thanks @nucleogenesis ! |
Summary
/deep/
KTextTruncator styles from AccessibleResourceCard.References
Addresses learningequality/kolibri-design-system#958
Reviewer guidance
Summary by CodeRabbit
Style
Chores