Skip to content

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented May 12, 2025

Summary

References

Addresses learningequality/kolibri-design-system#958

Reviewer guidance

  • Import resources with long words/ links in the description.
  • Go to coach > Lessons > Manage resources and check that cards are displayed correctly.
  • Check that no regressions exists in any other card within the resource selection side panels.

Summary by CodeRabbit

  • Style

    • Removed custom word-breaking CSS for description text in resource cards, restoring default text wrapping behavior.
  • Chores

    • Updated design system dependency to reference a specific commit from a GitHub repository.

Copy link
Contributor

coderabbitai bot commented May 12, 2025

Walkthrough

The changes remove a custom CSS override from the AccessibleResourceCard component and update the kolibri-design-system dependency in the kolibri package to reference a specific commit from a GitHub repository instead of a version number.

Changes

File(s) Change Summary
packages/kolibri-common/components/Cards/AccessibleResourceCard.vue Removed custom CSS that previously overrode word-breaking behavior for the KTextTruncator component.
packages/kolibri/package.json Updated kolibri-design-system dependency to use a GitHub commit reference instead of a fixed version.

Sequence Diagram(s)

No sequence diagram is generated as the changes are limited to styling and dependency updates, without affecting control flow or feature logic.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a6df04 and d64c7d2.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • packages/kolibri-common/components/Cards/AccessibleResourceCard.vue (0 hunks)
  • packages/kolibri/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • packages/kolibri-common/components/Cards/AccessibleResourceCard.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build WHL file / Build WHL
🔇 Additional comments (1)
packages/kolibri/package.json (1)

81-81:

❓ Verification inconclusive

Dependency should point to the official KDS repo, not a personal fork
The current entry references Alex’s fork (https://github.com/AlexVelezLl/kolibri-design-system.git#…), which can introduce maintenance and trust issues. It’s better to reference the upstream Learning Equality repository (and the specific PR commit) directly. Also verify that your package manager accepts this URL format and regenerate your lockfile.

Suggested diff:

-    "kolibri-design-system": "https://github.com/AlexVelezLl/kolibri-design-system.git#c67493ef3f9a2de032739353b0a49415f2f49288",
+    "kolibri-design-system": "git+https://github.com/learningequality/kolibri-design-system.git#c67493ef3f9a2de032739353b0a49415f2f49288",

After applying, run:

to ensure the lockfile is updated correctly.


🏁 Script executed:

npm install   # or yarn install

Length of output: 1849


Point kolibri-design-system to the official Learning Equality repo
Replace the forked URL with the upstream KDS repository and regenerate the lockfile.

  • packages/kolibri/package.json, line 81

Suggested diff:

-    "kolibri-design-system": "https://github.com/AlexVelezLl/kolibri-design-system.git#c67493ef3f9a2de032739353b0a49415f2f49288",
+    "kolibri-design-system": "git+https://github.com/learningequality/kolibri-design-system.git#c67493ef3f9a2de032739353b0a49415f2f49288",

After updating, run:

npm install   # or yarn install

and confirm there are no dependency‐tree errors. If you see peer‐dependency conflicts (e.g., aphrodite), resolve them upstream or rerun with --legacy-peer-deps, then commit the regenerated lockfile.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented May 12, 2025

@nucleogenesis nucleogenesis self-assigned this May 15, 2025
@nucleogenesis nucleogenesis self-requested a review May 15, 2025 16:48
@pcenov
Copy link
Member

pcenov commented May 19, 2025

Thanks @AlexVelezLl - I confirm that this is implemented as specified and there are no regressions.

@radinamatic
Copy link
Member

radinamatic commented May 22, 2025

Manual QA passed, needs code review and approval! 🙂
cc @nucleogenesis

@AlexVelezLl AlexVelezLl changed the title [Do Not Merge] Remove deep KTextTruncator styles from AccessibleResourceCard Remove deep KTextTruncator styles from AccessibleResourceCard Jun 2, 2025
@AlexVelezLl AlexVelezLl force-pushed the test-resource-card branch from d69ea45 to 24d897e Compare June 2, 2025 19:17
@AlexVelezLl AlexVelezLl requested a review from marcellamaki June 2, 2025 19:20
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are 👍

@AlexVelezLl
Copy link
Member Author

Thanks @nucleogenesis !

@AlexVelezLl AlexVelezLl merged commit 3281c10 into learningequality:develop Jun 2, 2025
51 checks passed
@AlexVelezLl AlexVelezLl deleted the test-resource-card branch June 2, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants