Add questions url prop to Bloom player #13384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes update the Bloom player HTML to reference a new JavaScript build and modify the BloomRunner logic to load and pass a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BloomRunner
participant ZipFile
participant BloomPlayerIframe
User->>BloomRunner: Initiate Bloom content loading
BloomRunner->>ZipFile: Extract content, dist, meta, and questions.json
ZipFile-->>BloomRunner: Return URLs for each resource
BloomRunner->>BloomPlayerIframe: Construct iframe src with resource URLs as query params (including questionsJsonUrl)
BloomPlayerIframe-->>User: Render Bloom content with questions
Assessment against linked issues
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
kolibri/core/content/static/bloom/bloomPlayer-02a77592459cdf0b1bd7.min.jsis excluded by!**/*.min.js
📒 Files selected for processing (2)
kolibri/core/content/static/bloom/bloomplayer.htm(1 hunks)packages/hashi/src/Bloom/BloomRunner.js(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Frontend tests
- GitHub Check: All file linting
- GitHub Check: Build WHL file / Build WHL
🔇 Additional comments (2)
kolibri/core/content/static/bloom/bloomplayer.htm (1)
11-11: Appropriate update to use the newer Bloom player bundle.The JavaScript bundle reference has been updated to a new version that supports the
questionsJsonUrlparameter, which is essential for the fix described in the PR objectives.packages/hashi/src/Bloom/BloomRunner.js (1)
168-170: Good implementation for loading the questions.json file.The implementation correctly fetches the
questions.jsonfile from the ZIP archive and safely handles the case where it might not exist using the optional chaining operator.
Build Artifacts
|
rtibbles
reviewed
May 8, 2025
pcenov
approved these changes
May 12, 2025
There was a problem hiding this comment.
Thanks @AlexVelezLl - I confirm that the questions.json error is not appearing anymore and I didn't observe any regressions caused by the fix.
|
Thanks @pcenov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The security error shown in #13339 was being raised because the bloom player was referencing missing files in a blob url. The first one is because the bloom player was trying to fetch a
questions.jsonfile just concatenating the file name to theurlof the htm file, which is incorrect, since we haven't even built a blob url for this file. In Chrome it raises a 404 error, but in Firefox this raises this Security Error. The second security error shown in #13339 was because the bloom file was referencing aBasic Book.cssfile, but it was missing in the zip file, so there isn't much we can do there.So this PR:
questions.jsonblob url through search param to the bloom playerReferences
Closes #13339.
Reviewer guidance
Replicate #13339
Summary by CodeRabbit
New Features
Chores