Skip to content

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 1, 2025

Summary

  • Don't show inaccurate headers for practice quizzes.
  • Allow direct pressing of the "Select quiz" button when previewing the quiz.

References

Fixes issues observed by @marcellamaki while reviewing another PR

Reviewer guidance

Follow the select practice quiz workflow
Preview the quiz
Ensure all displayed buttons and information are relevant and functional.
Ensure quiz can be selected from the select quiz button and that it properly handles the selection action.

Allow direct pressing of the "Select quiz" button when previewing the quiz.
@rtibbles rtibbles added the P0 - critical Priority: Release blocker or regression label Apr 1, 2025
@rtibbles rtibbles requested a review from marcellamaki April 1, 2025 21:54
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Apr 1, 2025
@marcellamaki
Copy link
Member

@pcenov @radinamatic I've tagged this in as needs QA although I'm doing a first pass of manual QA now as I'm doing code review

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense to me, and the overall interaction seems to be working exactly as we discussed. The one lingering piece (which I didn't catch before) is that the snackbar continues to have the default 10 questions as the number added, rather than reflecting the actual number of questions. I've double checked, and the issue is specific to practice quizzes. I think it would be ideal to update this now as well if you don't mind.

Screen.Recording.2025-04-01.at.6.10.10.PM.mov

@rtibbles
Copy link
Member Author

rtibbles commented Apr 1, 2025

Thanks @marcellamaki I have updated - the current notification function was inferring the number of questions slightly magically, so I have changed it to take an explicit count instead and that seems to have resolved it.

Did a quick regression test on regular question adding (both auto select and manual) and no issues observed.

@pcenov pcenov self-requested a review April 2, 2025 10:00
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue reported by Marcella is fixed now, everything else looks good too.

@marcellamaki marcellamaki merged commit 06cdc88 into learningequality:develop Apr 2, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants