-
Notifications
You must be signed in to change notification settings - Fork 803
Clean up resource preview for practice quiz selection #13283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up resource preview for practice quiz selection #13283
Conversation
Allow direct pressing of the "Select quiz" button when previewing the quiz.
@pcenov @radinamatic I've tagged this in as needs QA although I'm doing a first pass of manual QA now as I'm doing code review |
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes make sense to me, and the overall interaction seems to be working exactly as we discussed. The one lingering piece (which I didn't catch before) is that the snackbar continues to have the default 10 questions as the number added, rather than reflecting the actual number of questions. I've double checked, and the issue is specific to practice quizzes. I think it would be ideal to update this now as well if you don't mind.
Screen.Recording.2025-04-01.at.6.10.10.PM.mov
Thanks @marcellamaki I have updated - the current notification function was inferring the number of questions slightly magically, so I have changed it to take an explicit count instead and that seems to have resolved it. Did a quick regression test on regular question adding (both auto select and manual) and no issues observed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue reported by Marcella is fixed now, everything else looks good too.
Summary
References
Fixes issues observed by @marcellamaki while reviewing another PR
Reviewer guidance
Follow the select practice quiz workflow
Preview the quiz
Ensure all displayed buttons and information are relevant and functional.
Ensure quiz can be selected from the select quiz button and that it properly handles the selection action.