Hide the 'Search' button when there's nothing to search for #13277
Conversation
github-actions
bot
added
APP: Coach
| @@ -23,6 +23,7 @@ | |||
| {{ selectFromBookmarks$() }} | |||
| </div> | |||
| <KButton | |||
| v-if="bookmarksCount > 0" | |||
There was a problem hiding this comment.
This will hide the search button unless the user has bookmarks. I am unsure how this is fixing the issue?
I think you probably intended to do the same if statement here as below, conditionalised on channels.length.
There was a problem hiding this comment.
Ohh my bad , I see the point. Fixed now I think
Build Artifacts
|
|
It looks like there's also a search button nested inside the QuizResourceSelectionHeader component here as well: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/coach/assets/src/views/common/resourceSelection/QuizResourceSelectionHeader.vue#L21 I know the original issue that was raised by @pcenov was just for lessons, but it looks like quizzes would also be affected. I see this component has a Can you test reproducing this issue for quiz resource selection as well, and if it reproduces we should add the same handling here. |
|
Yes I saw the prop too ! But I am not sure if I can reproduce it quiz . 
|
|
If you edit the quiz and then try to add questions would it not appear? |
|
Hi @AllanOXDi - I confirm that the Search button is now hidden in Lessons > Manage resources when there aren't any resources. quiz.mp4So it seems that this should be a follow-up issue as the Search button is not the only thing that should be handled better. |
|
Opened a follow up issue. |
Summary
This PR hides the 's the 'Search' button at all when there's nothing to search for
References
closes #13261
Reviewer guidance
Navigate to Coach > Lessons > Manage resources - See if the "Search" button is active with resources in devices Vs without it.