Skip to content

Fix question count reset when isChoosingManually changed #13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix question count reset when isChoosingManually changed #13263

merged 1 commit into from
Mar 27, 2025
+2 −7

Conversation

AlexVelezLl
Copy link
Member

Summary

  • Remove questionCount reset when isChoosingManually is changed to false. This was causing that the new question count was being ignored when we were turning isChoosingManually to false.

References

Closes #13262

Reviewer guidance

Replicate #13262.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Mar 27, 2025
@AlexVelezLl AlexVelezLl force-pushed the fix-first-questionCount-set branch from fc79764 to c211a1e Compare March 27, 2025 15:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0b1.dev0_git.138.g15417a41.pex
Windows Installer (EXE) kolibri-0.18.0b1.dev0+git.138.g15417a41-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0b1.dev0+git.138.g15417a41-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0b1.dev0+git.138.g15417a41.dmg
Android Package (APK) kolibri-0.18.0b1.dev0+git.138.g15417a41-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0b1.dev0+git.138.g15417a41.zip
TAR file kolibri-0.18.0b1.dev0+git.138.g15417a41.tar.gz
WHL file kolibri-0.18.0b1.dev0+git.138.g15417a41-py2.py3-none-any.whl

marcellamaki
marcellamaki approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlexVelezLl - code changes look fine and manual QA confirms.

@marcellamaki marcellamaki merged commit e7505b1 into learningequality:develop Mar 27, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Milestone
Kolibri 0.18: Coach Resource Discovery
Development

Successfully merging this pull request may close these issues.

Quizzes > Add questions - The value of the default 10 resources cannot be changed
3 participants
@AlexVelezLl @marcellamaki @rtibbles