Fix bugs in common CategorySearchModal #13056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Artifacts
|
AlexVelezLl
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Thanks @AllanOXDi! Code changes looks good to me! Will let QA do the final approval 👐.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CategorySearchModal not rendering work properly in windowIsSmall in Learn from the side panel
Before
Screen.Recording.2025-02-06.at.19.10.13.mov
After
Screen.Recording.2025-02-06.at.19.12.55.mov
References
#13033
Reviewer guidance
Navigate to learn > filter and try filter with different screen size option