Resolve webpack loaders and dependencies relative to kolibri-tools#12052
Merged
rtibbles merged 2 commits intolearningequality:release-v0.16.xfrom Apr 9, 2024
Merged
Resolve webpack loaders and dependencies relative to kolibri-tools#12052rtibbles merged 2 commits intolearningequality:release-v0.16.xfrom
rtibbles merged 2 commits intolearningequality:release-v0.16.xfrom
Conversation
Contributor
Build Artifacts
|
rtibbles
reviewed
Apr 5, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
This looks good to go, and should make kolibri-tools more robust overall. We'll hold on merging until 0.16.1 has been released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Where you can find the dependencies for each of a project's dependencies depends on that project's package manager. With Studio using
pnpm, the webpack config becomes relative to the Studio context, and Studio does not declare these dependencies, because it relies onkolibri-toolsas a toolbox for all of them.This PR updates the webpack config to use
require.resolveon any Webpack loader or plugin that is passed by its string package name. It also updateskolibri-toolsto import all node-specific dependencies using thenode:protocolReferences
Required by: learningequality/studio#4462
Reviewer guidance
Does anything break?
Testing checklist
PR process
Reviewer checklist
yarnandpip)