Add IMS Content Package support to the HTML5 Viewer#11436
Merged
rtibbles merged 2 commits intolearningequality:release-v0.16.xfrom Oct 23, 2023
Merged
Add IMS Content Package support to the HTML5 Viewer#11436rtibbles merged 2 commits intolearningequality:release-v0.16.xfrom
rtibbles merged 2 commits intolearningequality:release-v0.16.xfrom
Conversation
Contributor
Build Artifacts
|
Member
Author
|
Test failure was a known flaky test :/ |
nucleogenesis
approved these changes
Oct 23, 2023
Member
nucleogenesis
left a comment
There was a problem hiding this comment.
LGTM. Funny that you have to enumerate every choice even though you're just adding one 😆
Member
Author
|
Yeah, and it's also not even a database enforced constraint, so the migration doesn't make that much sense either! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Pre-emptive support for IMSCP import when learningequality/studio#4258 is merged - it properly handles and relies on the pre-existing
entryoption for HTML5 apps in order to render the relevant resource from within an IMS Content Package.Reviewer guidance
This is a little difficult for now - but it will make testing the Studio side easier once that's merged - a bit chicken and egg!
Testing checklist
PR process
Reviewer checklist
yarnandpip)