Skip to content

Remote browsing filter fixes#10974

Merged
rtibbles merged 4 commits intolearningequality:developfrom
rtibbles:remote_browsing_filters
Jul 13, 2023
Merged

Remote browsing filter fixes#10974
rtibbles merged 4 commits intolearningequality:developfrom
rtibbles:remote_browsing_filters

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 13, 2023

Summary

  • Fixes uncaught Python 2.7 compatibility issue with remote file browsing
  • Displays the search side panel for remote libraries on the channels page consistent with spec
  • Ensures that the device id parameter is preserved in the Folder and Search header tabs
  • Removes a residual guard that was no longer needed and causing an incorrect navigation to a page without the device id parameter

References

Fixes #10926
Fixes missing search panel referenced in #10931

Spec:
Screenshot from 2023-07-12 15-27-30

Reviewer guidance

Screencast.from.07-12-2023.08.00.01.PM.webm

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 13, 2023
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Jul 13, 2023
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @rtibbles! These changes look correct to me!

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well - the search and filters are now displayed and working correctly. I have reported separately the following 2 issues: #10975 and #10976

@rtibbles rtibbles merged commit 2549292 into learningequality:develop Jul 13, 2023
@rtibbles rtibbles deleted the remote_browsing_filters branch July 13, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote browsing - Search and filters are not working

3 participants