Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle urlparse ValueError on invalid IP addresses in python >= 3.11 #10854

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

dbnicholson
Copy link
Contributor

See python/cpython#103848.

Summary

Fixes kolibri.core.discovery.test.test_network_utils.TestURLParsing.test_invalid_ipv6_address on Python 3.11+.

References

#10853

Reviewer guidance

See whether the test suite passes now.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Jun 15, 2023
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! Saved me installing 3.11.4 locally :)

@dbnicholson
Copy link
Contributor Author

Cheers! Saved me installing 3.11.4 locally :)

I didn't actually run 3.11, I'm just going to see what the CI thinks. 😸

@rtibbles rtibbles merged commit 8bdccc4 into learningequality:develop Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants