-
Notifications
You must be signed in to change notification settings - Fork 101
Fixes for DocsExample
: Add support for SCSS
language and block
attribute
#965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DocsExample
: Add support for SCSS
language and block
attribute
Please take a look @MisRob @EshaanAgg whenever possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @Pandaa007! These look good to me. Thanks for fixing the SCSS
error in the PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both @Pandaa007 and @EshaanAgg
@Pandaa007 @EshaanAgg there's a tiny hiccup, in the production build, one of the colleagues noticed that
|
Ahh. Some of the |
No problem, thank you. It'd be also fine to just open an issue, whatever you prefer @EshaanAgg. We can write .vue to URL meanwhile, not a big deal :) |
Description
SCSS
language inDocsExample
DocsExample
component to make use ofDocsShow
with support forblock
propKImg
documentation to make use of the same as a proof of conceptblock
attribute to existing documentation pages to ensure consistency in their look and feelIssue addressed
Fixes the problems discussed in #962
Changelog
DocsExample
to provide support forSCSS
language andblock
attributeTesting checklist
Reviewer guidance
Comments