Skip to content

Conversation

rtibbles
Copy link
Member

Description

  • Restores a watcher that helps keep the internal selection state of KSelect in line with the value prop

Changelog

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes makes sense, and just tested it on Kolibri, and can confirm that this fixes learningequality/kolibri#12821.

@AlexVelezLl AlexVelezLl merged commit d4d1e81 into develop Nov 26, 2024
11 checks passed
@AlexVelezLl AlexVelezLl deleted the rtibbles-patch-2 branch November 26, 2024 20:34
learning-equality-bot bot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants