Improve action that manages issue headers#28
Conversation
MisRob
force-pushed
the
issue-header-action
branch
10 times, most recently
from
0c7e9fa to
d27caa4
Compare
- Move shared part to a separate file - Trigger on open new issue event - Remove header from templates
MisRob
force-pushed
the
issue-header-action
branch
from
d27caa4 to
9472b9a
Compare
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Code changes make sense - a couple of comments related to events.
|
|
||
| on: | ||
| issues: | ||
| types: [opened, labeled, unlabeled] |
There was a problem hiding this comment.
Just to cover some edge cases we can add reopened and transferred to this list.
There was a problem hiding this comment.
Ah yes, thank you. I only added reopened here. I played around with transferred and the way it works is that a receiving repository will run opened event on issues that are transferred into it, so it's covered. However I updated the script to handle better both reopened and transferred issues. Tested successfully.
| manage-issue-header: | ||
| runs-on: ubuntu-latest | ||
| if: | | ||
| github.event.action == 'opened' || |
There was a problem hiding this comment.
Would need to add the other event names here too, presumably.
MisRob
force-pushed
the
issue-header-action
branch
from
2ce9708 to
3251d3d
Compare
|
@rtibbles Companion pull requests:
We should merge this one and the five above together. |
|
@rtibbles I also pushed upgrade of dependencies and caching of node dependencies here. Tested the latest version on |
| - name: Install dependencies | ||
| run: npm install | ||
| run: yarn install --frozen-lockfile |
There was a problem hiding this comment.
This is yarn's version of npm ci - I've recently learned it's recommended approach in workflows. This is also a a reason why I am committing yarn.lock. When I have a while, I will upgrade and improve other community related workflows similarly.
2 participants
Summary
Improve action that manages issue headers:
I've developed and previewed in my replica of LE's GitHub, and also tested in
test-actions40caf0f.References
Follow-ups for @rtibbles recent feedback.
Reviewer guidance
Please don't merge. After approval, I will open companion PRs in the five repositories, and then we can merge everything together.