React router update

[Matt-Eva]

No description provided.

[lizbur10]

This is looking good. A few things:

1. It doesn't really make sense to me that a list of MovieCard components is rendered on the Home page and then students are asked to add code to render the same info on the Movie page. I suggest just having students render a list of movie titles on the home page and then use the UserCard on the Movie page
2. It might be a good idea to mention that translating titles into routes (and back) will be handled automatically so students don't need to worry about it.
3. When I run the tests I'm getting an error about "/bad-route" not being found (in the test of the error page). The tests are all passing but it would probably be good if we can find a way suppress or clear that error.
4. The tests are also throwing warnings about using the regex global modifier. I just removed them from my test files and it worked fine so I'll do that here as well.

[lizbur10]

Removing global flag from test files

[Matt-Eva]

Thanks for the feedback, Liz! I think those are all good changes.

1. I agree that we should probably just render the titles to our Home Page, along with a link directing a user to view info (I've learned that it's accessibility best practice to not nest links within header tags). I do think it would still make more sense to use MovieCards on Home to render the list of titles, as Card components seem to be traditionally used to render lists of information. Using it on the Movie Page component might be a little redundant, since that page is only rendering info about a single movie anyway.
2. Good call! I'll add a note about URL encoding.
3. Thanks for flagging. I'll look into that and see if I can replicate the error.
4. I did notice that when I was changing the tests. Thank you for fixing that!

[Matt-Eva]

Ok, I've been coding through the solution, and I've found some problems.

1. Our tests aren't currently checking for MovieCards at all. We pass all of the tests if we just render Home Page on the home page route. So we'll need to add some tests for both of these components, I think.
2. Our tests aren't currently checking if either NavBar or our ErrorPage are rendering for every route - they just check if they're being rendered on our Home Route.
3. @lizbur10 R.e. the error you received regarding "/bad-route": Did it look like this?

console.warn No routes matched location "/bad-route"

That's what I see even with all the tests passing.

4. I'm also seeing this console message pop up for our Home test file:

A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

I'm not sure what this is referring to, but can keep digging into it.

[lizbur10]

This is looking really great! A made a few more very minor suggestions (mostly punctuation 🙂 )