-
Notifications
You must be signed in to change notification settings - Fork 9.7k
More Functions #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kenjelly22
wants to merge
7
commits into
learn-co-curriculum:master
Choose a base branch
from
kenjelly22:more-functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
More Functions #35
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8f82d72
Pass tests 1-3 for saturdayFun
kenjelly22 f3541c2
Pass tests 1-3 for mondayWork
kenjelly22 b875951
Re-do saturdayFun with template literals and default argument
kenjelly22 5811527
Re-do mondayWork with template literals and default argument
kenjelly22 54ddfba
Refactor mondayWork as a function expression
kenjelly22 8a934ff
Create code for wrapAdjective that works but doesn't pass tests
kenjelly22 1e13c18
Refactor wrapAdjective as scope chain
kenjelly22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1 +1,25 @@ | ||||||||||||||||||||||||
// code your solution here | ||||||||||||||||||||||||
function saturdayFun(activity = "roller-skate") { | ||||||||||||||||||||||||
switch (activity) { | ||||||||||||||||||||||||
case "bathe my dog": | ||||||||||||||||||||||||
activity = "bathe my dog"; | ||||||||||||||||||||||||
} | ||||||||||||||||||||||||
return `This Saturday, I want to ${activity}!`; | ||||||||||||||||||||||||
} | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
const mondayWork = function (activity = "go to the office") { | ||||||||||||||||||||||||
switch (activity) { | ||||||||||||||||||||||||
case "work from home": | ||||||||||||||||||||||||
activity = "work from home"; | ||||||||||||||||||||||||
} | ||||||||||||||||||||||||
Comment on lines
+10
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same idea here. |
||||||||||||||||||||||||
return `This Monday, I will ${activity}.`; | ||||||||||||||||||||||||
}; | ||||||||||||||||||||||||
mondayWork(); | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
function wrapAdjective(string = "*") { | ||||||||||||||||||||||||
const innerFunction = function (adjective = "special") { | ||||||||||||||||||||||||
return `You are ${string}${adjective}${string}!`; | ||||||||||||||||||||||||
}; | ||||||||||||||||||||||||
return innerFunction; | ||||||||||||||||||||||||
} | ||||||||||||||||||||||||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||
|
||||||||||||||||||||||||
wrapAdjective()(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would also pass the test: