Skip to content

Add Progress bar while deploying to s3 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pratishshr merged 1 commit into from
Oct 31, 2019
Merged

Add Progress bar while deploying to s3 #30

pratishshr merged 1 commit into from
Oct 31, 2019

Conversation

@razzkumar
Copy link
Contributor

@razzkumar razzkumar commented Oct 30, 2019

changes

  • Add progress bar on s3 upload by using "github.com/schollz/progressbar/v2"

progressbar

I am unable to print newline due to logger.Info() showing time on the same line I have used
fmt.Println()
Resolve #14

@razzkumar razzkumar requested a review from pratishshr October 30, 2019 12:11
@pratishshr
Copy link
Contributor

pratishshr commented Oct 31, 2019

👍

@pratishshr pratishshr merged commit e468834 into dev Oct 31, 2019
@razzkumar razzkumar deleted the s3-deployment-progressbar branch October 31, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pratishshr pratishshr Awaiting requested review from pratishshr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@razzkumar @pratishshr