Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to cover initializeMiddleware function #45

Merged
merged 7 commits into from
Nov 27, 2019
Merged

Add tests to cover initializeMiddleware function #45

merged 7 commits into from
Nov 27, 2019

Conversation

parwatcodes
Copy link
Contributor

Resolves #38

  • Added node-mocks-http package to mockup Request and Response objects.
  • Added test suite & cases to cover initializeMiddleware function.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019 •
edited
Loading

Codecov Report

Merging #45 into master will increase coverage by 7.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   86.61%   93.66%   +7.04%     
==========================================
  Files           5        5              
  Lines         142      142              
  Branches       24       24              
==========================================
+ Hits          123      133      +10     
+ Misses         15        6       -9     
+ Partials        4        3       -1
Impacted Files Coverage Δ
src/impl/domain.ts 97.43% <0%> (+1.28%) ⬆️
src/index.ts 87.71% <0%> (+15.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c846e...54e6505. Read the comment docs.

@parwatcodes parwatcodes force-pushed the test-to-cover-initializeMiddleware-fn branch from 7210140 to f90d212 Compare November 26, 2019 11:55
@parwatcodes parwatcodes force-pushed the test-to-cover-initializeMiddleware-fn branch from f90d212 to 7f01e02 Compare November 26, 2019 12:02
@kabirbaidhya kabirbaidhya changed the title Test to cover initializeMiddleware function Add tests to cover initializeMiddleware function Nov 26, 2019
@parwatcodes parwatcodes force-pushed the test-to-cover-initializeMiddleware-fn branch from a08e9c5 to 6f6a11f Compare November 26, 2019 18:19
mesaugat
mesaugat reviewed Nov 26, 2019
View reviewed changes
test/domain.test.ts Outdated Show resolved Hide resolved
kabirbaidhya
kabirbaidhya reviewed Nov 27, 2019
View reviewed changes
test/domain.test.ts Outdated Show resolved Hide resolved
kabirbaidhya
kabirbaidhya reviewed Nov 27, 2019
View reviewed changes
test/domain.test.ts Outdated Show resolved Hide resolved
kabirbaidhya
kabirbaidhya reviewed Nov 27, 2019
View reviewed changes
test/domain.test.ts Outdated Show resolved Hide resolved
kabirbaidhya
kabirbaidhya reviewed Nov 27, 2019
View reviewed changes
test/domain.test.ts Outdated Show resolved Hide resolved
@parwatcodes
Test cases to check whether a store is initialized through middleware…
45f9ac5 
… moved under isInitialized suite, and some code enhancements
@parwatcodes parwatcodes force-pushed the test-to-cover-initializeMiddleware-fn branch from e268518 to 45f9ac5 Compare November 27, 2019 05:08
kabirbaidhya
kabirbaidhya approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@kabirbaidhya kabirbaidhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. Thanks! Merging.

@kabirbaidhya kabirbaidhya merged commit 82fde26 into leapfrogtechnology:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesaugat mesaugat mesaugat left review comments

@kabirbaidhya kabirbaidhya kabirbaidhya approved these changes

Assignees

@parwatcodes parwatcodes

Labels
coverage test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests to cover initializeMiddleware function
4 participants
@parwatcodes @codecov-io @kabirbaidhya @mesaugat