Skip to content

DropdownMenu composition#54

Merged
mwarman merged 11 commits intomainfrom
5-dropdown-composition
Feb 27, 2025
Merged

DropdownMenu composition#54
mwarman merged 11 commits intomainfrom
5-dropdown-composition

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Feb 27, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

The DropdownMenu may be viewed in Storybook. There are some quirks in how Storybook renders the component inside of the preview panel due to the Backdrop component used by DropdownMenu using fixed positioning.

Within the app, these changes may be tested by...

  1. Click the Language Toggle button in the header of the application.
  2. The language toggle is the example of a DropdownMenu implementation within the app.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman added the enhancement New feature or request label Feb 27, 2025
@mwarman mwarman self-assigned this Feb 27, 2025
@mwarman mwarman linked an issue Feb 27, 2025 that may be closed by this pull request
@mwarman mwarman merged commit e0793ac into main Feb 27, 2025
5 checks passed
@mwarman mwarman deleted the 5-dropdown-composition branch February 27, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown composition

1 participant