Skip to content

Alert composition#51

Merged
mwarman merged 7 commits intomainfrom
47-alert-composition
Feb 23, 2025
Merged

Alert composition#51
mwarman merged 7 commits intomainfrom
47-alert-composition

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Feb 23, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

  • fixes Alert composition #47
  • Update the Alert component to use component composition.
  • Added the AlertContent, AlertHeader, AlertTitle, and AlertDescription components to compose the content of an Alert.
  • Added the ErrorAlert component which provides an opinionated composition of an error alert block.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. You may use Storybook to view the Alert.

Alternatively you may view alerts by:

  1. Sign in with invalid credentials.
  2. Create a task and then try to edit that task.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Feb 23, 2025
@mwarman mwarman linked an issue Feb 23, 2025 that may be closed by this pull request
@mwarman mwarman added the enhancement New feature or request label Feb 23, 2025
@mwarman mwarman merged commit fe440a9 into main Feb 23, 2025
5 checks passed
@mwarman mwarman deleted the 47-alert-composition branch February 23, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert composition

1 participant