Skip to content

use cva#46

Merged
mwarman merged 9 commits intomainfrom
42-use-cva-in-common-components-with-variant-attributes
Feb 19, 2025
Merged

use cva#46
mwarman merged 9 commits intomainfrom
42-use-cva-in-common-components-with-variant-attributes

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Feb 19, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

List the changes included in this pull request.

  • fixes Use cva in common components with variant attributes #42
  • Use the class-variance-authority library to provide the logic for variant attributes for components, e.g. variant, size, etc.
  • Created a Heading component and moved the logic to render HTML headings from the Text component to the new Heading component.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. Regression test.
  2. Components changed are: Alert, DialogButton, Tabs, Text, and Badge.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • ...

@mwarman mwarman added the enhancement New feature or request label Feb 19, 2025
@mwarman mwarman self-assigned this Feb 19, 2025
@mwarman mwarman linked an issue Feb 19, 2025 that may be closed by this pull request
@mwarman mwarman merged commit 183a64f into main Feb 19, 2025
5 checks passed
@mwarman mwarman deleted the 42-use-cva-in-common-components-with-variant-attributes branch February 19, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use cva in common components with variant attributes

1 participant