Skip to content

24 Slide to delete#34

Merged
mwarman merged 11 commits intomainfrom
24-slide-to-delete
Aug 8, 2024
Merged

24 Slide to delete#34
mwarman merged 11 commits intomainfrom
24-slide-to-delete

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Aug 8, 2024

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

List the changes included in this pull request.

  • Issue: Slide to delete #24
  • On the small viewport user list, add a slide option to delete the user.
  • On all viewport sizes add a progress bar to the header which may be used to indicate a loading state.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. Test deleting users in mobile and web viewport sizes.
  2. Test using both the delete button and the slide to delete approach.
  3. Test with a slow network to view the progress indicator in the Header when deleting a user.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • ...

@mwarman mwarman added the enhancement New feature or request label Aug 8, 2024
@mwarman mwarman self-assigned this Aug 8, 2024
@mwarman mwarman linked an issue Aug 8, 2024 that may be closed by this pull request
@mwarman mwarman merged commit ab97771 into main Aug 8, 2024
@mwarman mwarman deleted the 24-slide-to-delete branch August 8, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slide to delete

1 participant