Skip to content

feat: update textmate grammar#682

Merged
mhuisi merged 1 commit intoleanprover:masterfrom
mhuisi:mhuisi/update-textmate-grammar
Oct 20, 2025
Merged

feat: update textmate grammar#682
mhuisi merged 1 commit intoleanprover:masterfrom
mhuisi:mhuisi/update-textmate-grammar

Conversation

@mhuisi
Copy link
Collaborator

@mhuisi mhuisi commented Oct 17, 2025

This PR adds newer keywords that have been added to Lean 4 and removes ones that have been removed from Lean 4 in the mean-time.

It also mitigates #609 by limiting the situations where character highlighting occurs and mitigates #515 by not attempting to highlight the brackets (and thus needing to find a closing bracket) when the attribute declaration has parameters. Given the nature of the TextMate grammar, neither of these are complete fixes.

#369 and #656 remain problematic for now. In the future, we are planning to replace the markdown highlighting in the TextMate grammar with semantic highlighting in the language server.

Closes #609, closes #515.

@mhuisi mhuisi force-pushed the mhuisi/update-textmate-grammar branch from 34101df to 89429bc Compare October 17, 2025 11:40
@mhuisi mhuisi mentioned this pull request Oct 17, 2025
@mhuisi mhuisi merged commit 7071db8 into leanprover:master Oct 20, 2025
2 checks passed
@mhuisi mhuisi deleted the mhuisi/update-textmate-grammar branch October 21, 2025 12:42
@mhuisi mhuisi restored the mhuisi/update-textmate-grammar branch October 28, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notation x[...]'... gets confused with a character literal Incorrect highlighting if deprecation message contains ] character

1 participant