Skip to content

fix: adhoc files should not pick up default lean version from open folder#231

Merged
Vtec234 merged 3 commits intomasterfrom
clovett/fix_adhoc
Aug 1, 2022
Merged

fix: adhoc files should not pick up default lean version from open folder#231
Vtec234 merged 3 commits intomasterfrom
clovett/fix_adhoc

Conversation

@lovettchris
Copy link
Contributor

@lovettchris lovettchris commented Jul 28, 2022

fixes #227

@Vtec234
Copy link
Member

Vtec234 commented Jul 29, 2022

Hm, could we ask Elan for what the default version is instead, and then use the 'select Lean toolchain' machinery to run that? I guess this will work but it's a bit complicated to make a temp folder just because the Lean version is selected based on cwd.

@lovettchris
Copy link
Contributor Author

lovettchris commented Jul 29, 2022

Hm, could we ask Elan for what the default version is instead, and then use the 'select Lean toolchain' machinery to run that? I guess this will work but it's a bit complicated to make a temp folder just because the Lean version is selected based on cwd.

@Vtec234 - done. It now forces adhoc files to use the elan default toolchain, with the side effect that if there is no default it installs the nightly build as the new default.

@Vtec234 Vtec234 merged commit 80a7d00 into master Aug 1, 2022
@Vtec234
Copy link
Member

Vtec234 commented Aug 1, 2022

Thanks!

@lovettchris lovettchris deleted the clovett/fix_adhoc branch August 1, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Untitled files no longer work

2 participants