perf: improve avoidance of repeated Expr visits in unused variables linter #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomeata
approved these changes
Dec 15, 2023
|
!bench |
github-actions
bot
added
the
toolchain-available
|
This comment was marked as outdated.
This comment was marked as outdated.
Kha
force-pushed
the
unused-avoid-revisit
branch
from
a3b172b to
960ac3d
Compare
|
!bench |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 15, 2023
|
Here are the benchmark results for commit 960ac3d. Benchmark Metric Change
===================================================
- stdlib attribute application 1.9% (13.0 σ)
- stdlib tactic execution 1.9% (17.0 σ)
- stdlib type checking 1.5% (10.1 σ) |
leanprover-community-mathlib4-bot
added
the
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 15, 2023
|
-23% build linting (~-0.2% total) in mathlib http://speed.lean-fro.org/mathlib4/compare/e7b27246-a3e6-496a-b552-ff4b45c7236e/to/37a93235-2a4d-4fcd-974d-b156a9667bcf?hash1=5ab702165bf2cf46d4f4aca462c197c3c201be5d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-43% linter run time in a big proof case