Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention x:h@e variant in docstring of x@e #3073

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 14, 2023

This was done in 1c1e6d7

Zulip thread

@nomeata
Copy link
Collaborator

nomeata commented Dec 14, 2023

Thanks! BTW, in this repo, the PR description becomes the commit message, so if you remove empty ### Summary sections etc. then I don’t have to :-)

auto-merge was automatically disabled December 14, 2023 18:14

Head branch was pushed to by a user without write access

@eric-wieser
Copy link
Contributor Author

Perhaps the PR template should make that obvious; I thought I was expected to leave the heading, since the template added it for me!

Comment on lines +672 to +673
/-- `x@e` or `x:h@e` matches the pattern `e` and binds its value to the identifier `x`.
If present, the identifier `h` is bound to a proof of `x = e`. -/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomeata, I pushed this docstring too

@nomeata
Copy link
Collaborator

nomeata commented Dec 14, 2023

Perhaps the PR template should make that obvious; I thought I was expected to leave the heading, since the template added it for me!

I guess the heading wouldn’t hurt if actual content followed it :-).

But yes, the commit-from-pr-description workflow seems to work nicely, so I should refine the template.

@nomeata
Copy link
Collaborator

nomeata commented Dec 14, 2023

Would you find the phrasing in #3074 more helpful? Feel free to suggest improvements over there.

@nomeata nomeata changed the title doc: remove outdated TODO doc: mention x:h@e variant in docstring of x@e Dec 14, 2023
@nomeata nomeata added this pull request to the merge queue Dec 14, 2023
Merged via the queue into leanprover:master with commit 430f4d2 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants