Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default compiler.enableNew to false until development restarts #3034

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

Kha
Copy link
Member

@Kha Kha commented Dec 6, 2023

No description provided.

@Kha Kha requested a review from leodemoura as a code owner December 6, 2023 10:12
@Kha Kha enabled auto-merge December 6, 2023 10:12
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 6, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Dec 6, 2023

  • ❗ Mathlib CI will not be attempted unless you rebase your PR onto the 'nightly' branch. (2023-12-06 10:29:37)
  • ✅ Mathlib branch lean-pr-testing-3034 has successfully built against this PR. (2023-12-20 23:22:11) View Log
  • ✅ Mathlib branch lean-pr-testing-3034 has successfully built against this PR. (2023-12-21 00:57:42) View Log

@Kha
Copy link
Member Author

Kha commented Dec 6, 2023

@leodemoura There is a number of tests testing new compiler output that are now broken. We could disable the option for external users only but I think the time savings for building Lean itself are significant enough to justify moving these tests into a new folder that is not part of the suite for now.

@Kha
Copy link
Member Author

Kha commented Dec 15, 2023

I've moved the new compiler tests to a separate directory that is currently not included in the test suite

@Kha Kha added the will-merge-soon …unless someone speaks up label Dec 15, 2023
@Kha Kha added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2023
@Kha Kha added the full-ci label Dec 20, 2023
@Kha Kha force-pushed the compiler-new-false branch 2 times, most recently from 2c3dce1 to 3d00588 Compare December 20, 2023 17:18
@Kha
Copy link
Member Author

Kha commented Dec 20, 2023

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 3d00588.
There were significant changes against commit 79c7b27:

  Benchmark                  Metric         Change
  =============================================================
+ import Lean                branches        -5.7%   (-211.8 σ)
+ import Lean                instructions    -5.9%   (-276.7 σ)
+ import Lean                maxrss         -16.6%  (-1346.8 σ)
+ lake build no-op           maxrss          -7.6%   (-165.8 σ)
+ lake config elab           instructions   -31.7%  (-3373.8 σ)
+ lake config elab           maxrss         -12.5%   (-359.6 σ)
+ lake config elab           task-clock     -25.5%    (-35.4 σ)
+ lake config elab           wall-clock     -25.4%    (-36.1 σ)
+ lake config import         instructions    -2.5%   (-208.2 σ)
+ lake config import         maxrss         -12.2%   (-406.3 σ)
+ lake config tree           instructions    -3.1%    (-59.2 σ)
+ lake config tree           maxrss         -12.5%   (-368.9 σ)
+ lake env                   instructions    -2.5%    (-96.8 σ)
+ lake env                   maxrss         -12.2%   (-307.3 σ)
+ reduceMatch                instructions    -2.8%  (-1142.9 σ)
+ reduceMatch                maxrss         -15.8%  (-1341.6 σ)
+ stdlib                     instructions   -30.5% (-69991.5 σ)
+ stdlib                     maxrss         -11.2%    (-23.4 σ)
+ stdlib                     task-clock     -26.7%   (-105.8 σ)
+ stdlib                     wall-clock     -28.1%    (-37.8 σ)
+ stdlib size                bytes .olean   -30.1%
+ tests/bench/ interpreted   instructions    -3.7%  (-2690.3 σ)
+ tests/bench/ interpreted   maxrss         -15.6%   (-729.8 σ)
+ tests/bench/ interpreted   task-clock      -8.0%    (-10.1 σ)
+ tests/bench/ interpreted   wall-clock      -6.9%    (-14.4 σ)
+ workspaceSymbols           instructions    -1.8%  (-3704.7 σ)
+ workspaceSymbols           maxrss         -17.3%   (-990.1 σ)

@Kha Kha force-pushed the compiler-new-false branch from 3d00588 to 9cd8a70 Compare December 20, 2023 21:09
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 20, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 20, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 21, 2023
@Kha Kha added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit bddb215 Dec 21, 2023
@Kha Kha deleted the compiler-new-false branch December 22, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants