feat: GuessLex: if no measure is found, explain why #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
I am not sure how well an ASCII-table works everywhere; the “Problems” pane of VSCode uses a proportional font. |
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 24, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
nomeata
added a commit
that referenced
this pull request
Nov 28, 2023
which also removes an error condition at the use site. While I am at it, I rename a parameter in `GuessLex` that I forgot to rename earlier. The effect will be user-visible (in obscure corner cases) with #2960, so I’ll have the test there. A few places would benefit from a `lambdaTelescopeBounded` that garantees the result has the right length (eta-expanding when necessary). I’ll look into that separately, and left TODOs here.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 28, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…erm (#2974) which also removes an error condition at the use site. While I am at it, I rename a parameter in `GuessLex` that I forgot to rename earlier. The effect will be user-visible (in obscure corner cases) with #2960, so I’ll have the test there. A few places would benefit from a `lambdaTelescopeBounded` that garantees the result has the right length (eta-expanding when necessary). I’ll look into that separately, and left TODOs here.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 1, 2023
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 1, 2023
nomeata
force-pushed
the
joachim/guess-lex-verbose
branch
from
f38d0ae to
b5e369d
Compare
nomeata
changed the title
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 1, 2023
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by showing the matrix of calls and measures, and what we know about that
call (=, <, ≤, ?), e.g.
It’s a bit more verbose for mutual functions.
It will use the user-specified argument names for functions written
but not with pattern matching like
This can be refined later and separately (and maybe right away in
expandMatchAltsWhereDecls).