-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rust-style raw string literals #2929
Conversation
|
Is there a particular reason (apart from copying Rust syntax) that this breaks the current Lean convention of having modifiers before strings with exclamation marks (think |
@hargoniX One perspective here is that interpStr starts with That's just a possible interpretation of the current situation, though I think the fact we only have interpStr modifiers is worth considering. Switching from |
@Kha I think this is ready for review |
!bench |
Here are the benchmark results for commit 205aa90. |
There is a ~1% parser run time regression. That sounds acceptable, but it might be worth a try avoiding the allocation for the |
For example, `r#"The word "this" is in quotes."#`. Implements leanprover#1422
@Kha I modified it to avoid allocation and to use the cheap I'll run the benchmarks again once the build succeeds. |
!bench |
!bench |
Here are the benchmark results for commit 781869c. |
For example,
r"\n"
andr#"The word "this" is in quotes."#
.Implements #1422