Include timings in trace messages when profiler is true
#1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
leodemoura
reviewed
Jan 3, 2023
src/Lean/Util/Trace.lean
Outdated
| (collapsed := true) : m α := do | ||
| if !(← isTracingEnabledFor cls) then | ||
| k | ||
| else | ||
| let ref ← getRef | ||
| let oldTraces ← getResetTraces | ||
| let res ← observing k | ||
| addTraceNode oldTraces cls ref (← msg res) collapsed | ||
| let (res, secs) ← withSeconds <| observing k |
There was a problem hiding this comment.
withSeconds is being executed even when profiler is set to false. Have you checked the impact on performance?
There was a problem hiding this comment.
I see you tried !bench! last week, but it seems it did not work.
|
!bench |
1 similar comment
|
!bench |
|
Here are the benchmark results for commit e089d1f. Benchmark Metric Change
========================================
- stdlib wall-clock 1% (33.3 σ) |
|
!bench |
|
Here are the benchmark results for commit 725117e. Benchmark Metric Change
========================================
- rbmap_1 task-clock 5% (15.6 σ)
- rbmap_1 wall-clock 5% (15.4 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rudimentary implementation. Would be interesting to have an "expand hot path" context menu item.