feat: show decl module in hover #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
force-pushed
the
hover_module
branch
from
c9bf955 to
e6246db
Compare
|
The namespace/module ambiguity strikes back 😅 . How about "from module |
Kha
reviewed
Sep 23, 2022
|
I suppose that example wasn't the best to use regarding namespace vs module. The namespace is already visible in the first line though, so I think it should be clear after a few examples? Using |
digama0
force-pushed
the
hover_module
branch
from
e6246db to
6425f65
Compare
leodemoura
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a in Foo.Bar.Module remark at the end of the hover display. This is helpful for knowing what to import to get access to a certain declaration you can see being used somewhere.
I was originally hoping to put a link there along the lines of rust-analyzer's "Go to MyType", but it turns out this is implemented via an LSP extension for "hover commands" and some client support, so I will leave it to the folks who are more involved in the frontend if they want to implement that.